Rust-sphlib: Looking for a Code Review


#1

Hi there.

I’ve never wrote any lines either in Rust or C before ) That’s why I’m here and would like to ask someone to review my code. I’ve decided to implement FFI bindings for sphlib as a part of studying a system programming.

Here is my pull, https://github.com/Zatvobor/rust-sphlib/pull/7. That would be great to get a feedback about what should be improved/changed at all. Many thanks.


#2

I left a few for you :slight_smile:


#3

Thanks dude.