Is a link to a GitHub PR okay on here??
If anyone has any spare time I'd love some comments from anyone 
Coding-wise, this looks fine, but from a project management perspective I don't like that the commit also makes unrelated changes (like changing the error type that some methods return) that aren't covered by the PR description. On the other hand, it's your repository, you can do what you want.
1 Like
I'm curious, are you making something similar to what I experimented with in GitHub - sermuns/git-sediment · GitHub? The name is suggestive of that!
Thank you for taking a look! I do need to get better at not scope crepping my PRs 
So I'm looking to re-implement pydriller but in Rust and then down the line looking to create Python bindings to then act as a drop in "replacement" for it, I may be delusional in that goal
So it looks like they're different but similar names (I'll concede I used GPT to help come up with a name, I'm particularly bad at picking a good name)
1 Like