Why doesn't rust warn about this missing match / typo?

[mroth]

@kp99-deleted

#![allow(unused)]

This is a pretty brave statement. Maybe check https://doc.rust-lang.org/rustc/lints/groups.html how many lints get knocked out by this (scroll to the bottom).

@kp99-deleted

I have unused off because warnings about unused usings are the LAST thing I want to see when working on code.

So you can use this:

#![allow(unused_imports)]`

---

@kp99-deleted

I tried setting #![deny(unused_variables)] in lib.rs. Sadly it causes a bunch of errors on unused function parameters too, and I have a lot of callbacks that sometimes don't need all the params they're passed.

Just add an initial underscore to unused variables:

fn some_callback(x: u32, _y: u32) -> u32 {
    x + 1
}

---

@kp99-deleted

As you can see, all I'm trying to do is use a plain old C-Style Enum as a bunch of const ints that I want to match on exhaustively.

Hmm, so Rust is not C. It's a different language, different style, different ideas, different solutions.

For experienced programmers in one language like you, it's not easy to unlearn some known patterns and to sink into the new language.

Maybe, some idea:

@kp99-deleted

use PlayerItemTypes::*;

pub enum PlayerItemTypes {
    MAGIC_LAMP,
    DEATH_DOLL,
    SCROLL_OF_EXIT,
}

Is it really necessary, to use upper case? Why not stick to Rust conventions?

Dump the unnecessary Types postfix, qualify enum members, use Self, remove unnecessary return, and omit the parenthesis in the match argument:

pub enum PlayerItem {
    MagicLamp,
    DeathDoll,
    ScrollOfExit,
}

impl PlayerItem {
    pub fn get_display_name(&self) -> &str {
        match self {
            Self::MagicLamp    => "Magic Lamp",
            Self::DeathDoll    => "Death Doll",
            Self::ScrollOfExit => "Scroll of Exit",
        }
    }
}