[TWiR] Call for Participation

joshlf · October 4, 2022, 11:40pm

mrinalwadhwa · October 5, 2022, 8:28pm

Hi everyone

Here are a couple of Ockam issues for this week's call:

Thank you for including us.

joshlf · October 9, 2022, 5:42pm

github.com/google/zerocopy

Miri can't run tests for `wasm32-wasi` target

opened 10:34PM - 04 Oct 22 UTC

joshlf

Hacktoberfest

[This job](https://github.com/google/zerocopy/actions/runs/3185884137/jobs/51959…43373) failed for reasons that seem specific to running `cargo miri test` with the target set to `wasm32-wasi`. I'm going to disable the test for the time being. Thanks to @frazar for discovering https://github.com/rust-lang/miri/issues/1916, which suggests that Miri lacks support for some wasm32 targets. The task for this issue now is to a) determine whether any wasm32 targets are supported, b) switch to using a supported one if so or, c) skip running Miri when targetting wasm32 if none are supported.

github.com/google/zerocopy

Test in CI that we have the same MSRV in all source files

opened 11:57PM - 09 Oct 22 UTC

joshlf

Our MSRV is used in a number of places: - Doc comment in `src/lib.rs` - `.gith…ub/workflows/ci.yml` - `zerocopy-derive/tests/trybuild.rs` - (eventually) `tests/trybuild.rs` Since they all need to be updated manually, it's easy for them to get out of sync. We should add a CI test that does some basic grep'ing to verify that they're in sync. ### Appendix: Other approaches I also tried to keep a single source of truth - an `MSRV.txt` file in the repository root that was sourced by other files. I ran into a few problems: - I was able to do the following to use that file to generate the crate-level doc comment: ```rust //! # Minimum Supported Rust Version (MSRV) //! #![doc = concat!("zerocopy's MSRV is ", include_str!("../MSRV.txt"), ".")] ``` ...unfortunately, the `cargo readme` tool we use to generate our `README.md` is not able to parse this, and so simply stops parsing the doc comment as soon as it encounters the `#![doc = ...]` line. - In `zerocopy-derive/tests/trybuild.rs`, I wasn't able to replace `#[rustversion::stable(1.61.0)]` with an equivalent which used `MSRV.txt`

mrinalwadhwa · October 12, 2022, 6:29pm

Hi everyone

Here are a couple of Ockam issues for this week's call:

Thank you for including us.

joshlf · October 13, 2022, 3:06pm

github.com/google/zerocopy

Add defensive programming in `FromBytes::new_box_slice_zeroed`

opened 04:48AM - 15 Oct 22 UTC

joshlf

Hacktoberfest experience-hard blocking-next-release

In https://github.com/google/zerocopy/pull/63, we switched from manual bounds ch…ecking plus [`Layout::from_size_align_unchecked`](https://doc.rust-lang.org/nightly/core/alloc/struct.Layout.html#method.from_size_align_unchecked) to calling [`Layout::from_size_align`](https://doc.rust-lang.org/nightly/core/alloc/struct.Layout.html#method.from_size_align) and relying on its bounds checking. There seemed to be a bug in that bounds checking prior to 1.65.0, and so we wrote a test which we disabled on Rust versions prior to 1.65.0. The reasoning was that the worst that could happen was a failed allocation, so it wasn't actually dangerous to expose this bug in the API. https://github.com/dtolnay/semver/pull/294 deals with this as well, and takes a more defensive stance. It observes that allocation with an invalid `Layout` is actually UB, and if the API is somehow reachable via attacker-controlled input, it results in an easy-to-exploit path to attacker-controlled UB. I think we may want to add defenses along the same lines. The specific task is to: - Figure out what UB is possible when combining the code as currently written with the version of `Layout::from_size_align` on 1.64.0 - Modify `FromBytes::new_box_slice_zeroed` to ensure that that UB cannot be triggered - Leave a `// TODO(#67): ...` comment to remove the workaround once our MSRV is at least 1.65.0 - Add that TODO to the list for 1.65.0 kept in #67 - Remove the conditional compilation on `test_new_box_slice_zeroed_panics_isize_overflow` and update the comment there

github.com/google/zerocopy

Add tests for compilation failure

opened 10:57PM - 30 Sep 22 UTC

joshlf

Hacktoberfest experience-medium

We use the [`trybuild`](https://crates.io/crates/trybuild) crate to test that ze…rocopy-derive correctly rejects code that it ought to. We have the same running for zerocopy itself, but no tests have been written to make use of it. zerocopy's API uses trait bounds to make certain illegal code impossible to express; we should write `trybuild` tests that make sure that each illegal code pattern actually fails to compile. ## Contributing If you'd like to contribute to this issue, just look through zerocopy's API, find unsound behavior that ought to be impossible to express, and write a test to confirm that it's inexpressible! If you're not sure where to start, consider: - Does the API have any documented preconditions which ought to be enforced at compile time? - Does the API have any trait bounds? Write a test which fails to uphold one of these requirements. Here's a list of all of the APIs in zerocopy that have preconditions or trait bounds: - `FromBytes` (@IsaacCloos assigned) - [ ] `read_from` - [ ] `read_from_prefix` - [ ] `read_from_suffix` - `AsBytes` - [ ] `as_bytes_mut` - [ ] `write_to` - [ ] `write_to_prefix` - [ ] `write_to_suffix` - `LayoutVerified` - [ ] `new` - [ ] `new_from_prefix` - [ ] `new_from_suffix` - [ ] `new_slice` - [ ] `new_slice_from_prefix` - [ ] `new_slice_from_suffix` - [ ] `new_zeroed` - [ ] `new_from_prefix_zeroed` - [ ] `new_from_suffix_zeroed` - [ ] `new_slice_zeroed` - [ ] `new_slice_from_prefix_zeroed` - [ ] `new_slice_from_suffix_zeroed` - [ ] `new_unaligned` - [ ] `new_unaligned_from_prefix` - [ ] `new_unaligned_from_suffix` - [ ] `new_slice_unaligned` - [ ] `new_slice_unaligned_from_prefix` - [ ] `new_slice_unaligned_from_suffix` - [ ] `new_unaligned_zeroed` - [ ] `new_unaligned_from_prefix_zeroed` - [ ] `new_unaligned_from_suffix_zeroed` - [ ] `new_slice_unaligned_zeroed` - [ ] `new_slice_unaligned_from_prefix_zeroed` - [ ] `new_slice_unaligned_from_suffix_zeroed` - [ ] `into_ref` - [ ] `into_mut` - [ ] `into_slice` - [ ] `into_mut_slice` - [ ] `bytes` - [ ] `bytes_mut` - [ ] `read` - [ ] `write` - [ ] `Debug for LayoutVerified<B, T>` - [ ] `Debug for LayoutVerified<B, [T]>` - [ ] `Deref for LayoutVerified<B, T>` - [ ] `Deref for LayoutVerified<B, [T]>` - [ ] `DerefMut for LayoutVerified<B, T>` - [ ] `DerefMut for LayoutVerified<B, [T]>` - [ ] `Display for LayoutVerified<B, T>` - [ ] `Display for LayoutVerified<B, [T]>` - [ ] `Ord for LayoutVerified<B, T>` - [ ] `Ord for LayoutVerified<B, [T]>` - [ ] `PartialOrd for LayoutVerified<B, T>` - [ ] `PartialOrd for LayoutVerified<B, [T]>` - [ ] `Eq for LayoutVerified<B, T>` - [ ] `Eq for LayoutVerified<B, [T]>` - [ ] `PartialEq for LayoutVerified<B, T>` - [ ] `PartialEq for LayoutVerified<B, [T]>` - `Unalign` - [ ] `get` - [ ] `AsBytes for Unalign<T>` - [ ] `FromBytes for Unalign<T>` - [ ] `Copy for Unalign<T>` - [ ] `Clone for Unalign<T>` - [ ] `extend_vec_zeroed` - [ ] `insert_vec_zeroed` - [ ] `transmute!` macro

hannobraun · October 18, 2022, 10:13am

Hey folks!

Here is a Fornjot issue that I'd appreciate some help on: `export-validator` does not support Windows · Issue #1231 · hannobraun/Fornjot · GitHub

Thank you!

mrinalwadhwa · October 19, 2022, 7:00pm

Hi folks

Here are a couple of Ockam issues for this week's call:

Thank you for including us.

joshlf · October 21, 2022, 12:45am

github.com/google/zerocopy

Optimize caching in CI

opened 12:45AM - 21 Oct 22 UTC

joshlf

In CI, we use the [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache) …GitHub Action to cache certain build artifacts across runs. However, it seems from the README that we might be using it in a suboptimal way. A few observations: - Zerocopy has only one dependency, and `rust-cache` only caches dependencies, not crate artifacts (note that zerocopy-derive has more dependencies - and dependencies that are expensive to compile - so presumably benefits much more than zerocopy) - We generate a custom cache key which includes: - A hash of the Cargo features, but this presumably shouldn't have any effect on dependencies (at least in our case, since none of our Cargo features depend on dependencies' Cargo features) - A hash of `**/Cargo.lock`, but this is documented to be the default behavior anyway We should: - Figure out if there's a way to squeeze more benefit out for zerocopy (can we get `rust-cache` to cache any more artifacts?) - Don't include Cargo features in the cache - Don't include a hash of `**/Cargo.lock` in the cache - Go back over our use of `rust-cache` and its README with a fine toothed comb and see what else we're doing suboptimally cc @Swatinem in case there's anything obvious that jumps out at you!

Razican · October 21, 2022, 8:46am

In Boa, the JavaScript engine written in Rust, are taking part in Hacktoberfest, and we would like some help in some issues.

Especially in those that are causing the engine a panic.

mrinalwadhwa · October 26, 2022, 7:36pm

Hi everyone

Here are a couple of Ockam issues for this week's call:

Thank you for including us.

torfmaster · November 12, 2022, 10:59pm

Hi!

I have a few issues for people interested in smart meters (or just parsers):

automate generation of string and list types: Automate generation of list and string types · Issue #2 · torfmaster/hackdose-sml-parser · GitHub
add more obis codes Add more obis codes · Issue #3 · torfmaster/hackdose-sml-parser · GitHub

tomtau · November 24, 2022, 2:47pm

Hi everyone

There are quite a few open issues on pest if anyone's interested: Issues · pest-parser/pest · GitHub

Perhaps to highlight one for the upcoming week's call: RFC: Make white-space handling less confusing / more consistent with the introduction of an "adjacent selector": `,` · Issue #271 · pest-parser/pest · GitHub

There are also two issues for the pest's website if anyone's into Wasm (as highlighted on v2.5.0: introducing `pest_debugger` · Discussion #739 · pest-parser/pest · GitHub ):

dhardy · December 4, 2022, 10:12am

I'd like to see more testing of impl-tools.

It supports a number of things, including a more flexible #[derive], impl Self syntax, auto trait implementation over generic types, and singleton! { .. }.

There have been some good suggestions (better support for new-type wrappers, better error messages). Keep them coming!

jhpratt · December 12, 2022, 2:43am

adrianbenavides · December 14, 2022, 4:33pm

Hello! Could we have a couple of Ockam issues included in this week's call for participation?

We have more beginner-friendly issues available similar to the two described above.

Thank you!

adrianbenavides · December 20, 2022, 3:30pm

Hi again, we have new good first issues at Ockam this week! It would be awesome if they could be included in the newsletter

Thanks

shepmaster · January 6, 2023, 10:23pm

Kero · January 9, 2023, 4:22pm

Hello Everyone, I am one of the autors of Meilisearch and I would like to know if it would be possible to ask for help on these four issues?

When the `lat` and `lng` are strings the wrong error message is returned · Issue #3007 · meilisearch/meilisearch · GitHub
Bad latitude / Bad longitude should share a common message between the invalid sort and invalid filter · Issue #3006 · meilisearch/meilisearch · GitHub
When both `lat` and `lng` are missing it doesn't return the right error · Issue #3005 · meilisearch/meilisearch · GitHub
We must return an error for when `_geo` is not an object · Issue #3003 · meilisearch/meilisearch · GitHub

weiznich · January 10, 2023, 8:35am

The diesel project is looking for community contributions to the following issues:

adrianbenavides · January 17, 2023, 8:30am

Hello, we have some good first issues at Ockam:

GitHub CI: use global default shell in documentation.yml workflow
Modify clap command ockam start to set the node attribute's default value using attributes
Add optional --identity argument to clap command secure-channel-listener create and modify its API handler

Thanks and have a happy week!

Topic		Replies	Views
Rust open source project community	4	567	January 22, 2024
Rust Newcomer from Python	5	1403	September 18, 2020
Find a open source project to contribute? community	2	573	July 20, 2023
Blog contribution for TWiR community	10	759	September 2, 2020
Now Taking Submissions - This Month In Rust [August] community	4	901	January 12, 2023

Related Topics