Rust cargo test failed in Clion

kenming · June 25, 2023, 5:25am

I get some trouble to run all the tests in my IDE(Clion)

It looks like my cargo setting is incorrect. Is there any way to disable the -Z flag ?

/Users/xxxxx/.cargo/bin/cargo test --color=always --lib scalar_subquery_to_join --no-fail-fast --manifest-path /Users/xxxxx/gitrepo/apache/arrow-datafusion/datafusion/optimizer/Cargo.toml -- --format=json -Z unstable-options --show-output
Testing started at 13:00 ...
Finished test [unoptimized + debuginfo] target(s) in 0.36s
Running unittests src/lib.rs (target/debug/deps/datafusion_optimizer-7c3b1a376458cd37)
error: the option Z is only accepted on the nightly compiler
error: test failed, to rerun pass --lib
error: 1 target failed:
--lib

SebastianJL · June 25, 2023, 6:40am

If you haven't done that yet you could check the run configuration of your test and see if you accidentaly slipped in a -Z flag.

You can read more on run/debug configurations in the jetbrains documentation.

bjorn3 · June 25, 2023, 6:43am

Are you using the latest version of the rust plugin? Previous versions of rust accidentally accepted -Zunstable-options on stable and the rust plugin for intellij made use of this. With the latest rust release this was made an error as originally intended and as such the rust plugin made a change to stop using this.

bjorn3 · June 25, 2023, 6:47am

github.com/rust-lang/rust

Prevent stable `libtest` from supporting `-Zunstable-options`

rust-lang:master ← thomcc:disallow-unstable-libtest

opened 08:43AM - 12 Mar 23 UTC

thomcc

+6 -0

Took a while for me to get around to this but seems trivial (unless I'm missing …some reason this will break all our tests). Fixes #75526 Basically `libtest` already tries to handle this in https://github.com/rust-lang/rust/blob/501ad021b9a4fb2cd6a39e0302d22f169f6166b0/library/test/src/cli.rs#L310-L318 But that env var was not passed. I'm guessing at one point [this code](https://github.com/rust-lang/rust/blob/501ad021b9a4fb2cd6a39e0302d22f169f6166b0/src/bootstrap/compile.rs#L842-L844) (or a common ancestor) was used to compile the standard library/libtest, but that is no longer the case (or perhaps it never worked, I don't have time to go digging). I don't love that this is a "allow unstable by default" situation, as it means things like [`rustc-build-sysroot`](https://github.com/RalfJung/rustc-build-sysroot) could accidentally get unstable (CC @RalfJung) even if this is fixed here, but it's consistent with what happens in `rustc_feature`, so... yeah. This is user-facing after all, even if it's hard to imagine the outcome of that conversation being "lets continue allowing use of `-Zunstable-features` from stable rust" (especially since a `RUSTC_BOOTSTRAP=1`-shaped loophole remains)... I think it probably should get a vibe check in the t-libs meeting (and plausibly a relnote along the lines of "hey `cargo test -- -Zunstable-options --some --unstable --stuff=here` used to work on stable, that's been fixed, sorry"). I'll nominate it for that after CI comes up green (I've done a smoke check but don't know what (if anything) will need `bootstrap` to enable `RUSTC_BOOTSTRAP=1` when running tests) r? @jyn514

github.com/intellij-rust/intellij-rust

Disable test tool window on toolchain version >= 1.70-beta

intellij-rust:master ← intellij-rust:disable_test_tool_window_on_toolchain_version_greater_1.70-beta

opened 10:15AM - 29 May 23 UTC

vlad20012

+26 -6

(hot) Fixes #10512 IntelliJ Rust can't run Rust tests anymore on Rust 1.70-be…ta (which will be released as 1.70 stable this week) because of https://github.com/rust-lang/rust/pull/109044 (Stable Rust test framework does not support `-Z unstable-options --format json` options anymore) ![image](https://github.com/intellij-rust/intellij-rust/assets/3221931/3ab46588-ce2d-448b-8310-fbedebb36acc) I managed only to disable the test tool window if a user has a toolchain version above 1.70-beta. So the user will see just a raw terminal instead of a test tree: ![image](https://github.com/intellij-rust/intellij-rust/assets/3221931/34309966-5cd1-49d3-ab64-9da329ea79f4) changelog: Fix running tests on Rust 1.70

kenming · June 25, 2023, 8:10am

I'm not sure whether it is related or not, my rust version is 1.70.0.

rustc --version
rustc 1.70.0 (90c541806 2023-05-31)

I just reinstalled the rust plugin in clion but with no luck, the issue is still there.

bjorn3 · June 25, 2023, 10:36am

Do you have 0.4.196.5423-231/232 or another version of the rust plugin?

kenming · June 25, 2023, 10:48am

My rust plugin version is: 0.4.194.5382-223.

kenming · June 25, 2023, 10:49am

Anyway, after I reset my cargo/rustc version to 1.69.0, the issue is gone.

bjorn3 · June 25, 2023, 11:10am

According to https://plugins.jetbrains.com/plugin/8182-rust/versions that version is from before the fix. And if I read the version number correctly you will need a newer version of Clion to get the version of the rust plugin with the fix.

kenming · June 25, 2023, 11:17am

You are right!!.
After I upgraded my clion and uses the new version of the rust plugin, the issue is gone.
Thanks a lot for the kindly help! Appreciate a lot!

system · September 23, 2023, 11:18am

This topic was automatically closed 90 days after the last reply. We invite you to open a new topic if you have further questions or comments.