Requesting feedback: ssh-fetch-keys for openssh AuthorizedKeysCommand

code review
1

Hi all:

I'm looking for feedback on my first Rust program, a command-line utility that can be used as an AuthorizedKeysCommand for openssh which fetches and caches keys from online sources.

https://github.com/scottcwang/ssh-fetch-keys

  • Is the Rust idiomatic? To what extent do you think it would be helpful to split functions into other crates?
  • Is the program well designed -- are the implementation choices appropriate? Will it cause any problems in the real world?
  • Yes, I'll eventually get around to writing unit tests instead of testing by hand.

Let me know what you think!

Citation for some of the permissions code: https://github.com/coreos/ssh-key-dir.

2

This topic was automatically closed 90 days after the last reply. We invite you to open a new topic if you have further questions or comments.