Refactor help (winreg)

SmuSmu · January 8, 2020, 1:27pm

Hi,

can someone check my code GitHub - SmuSmu/OpAgent: Agent Software

My Problem is the following. I need to know what kind of RegValue (string, int, ...) a regkey is in order to correctly get the value. Or better have a generic function which works with all correctly.

I am very new to Rust and typesafe programming. So I expect I should use a kind of match? Or how should I handle this kind of Problem.

Thanks for your hints

notriddle · January 9, 2020, 1:44am

If you're talking about this code?

github.com

SmuSmu/OpAgent/blob/28241ff1e107e79f24e72d5eafb276161f0b6786/src/main.rs#L14


      
          use std::fs::File;
          use std::io::prelude::*;
          
          
fn regreadvalue_string (regpath: &str, regvalue: &str, mut inifile: &std::fs::File) {
              let hklm = winreg::RegKey::predef(HKEY_LOCAL_MACHINE);
          
          
    let subkey = hklm.open_subkey_with_flags(regpath, KEY_READ);
          
          
    match subkey {
                  Ok(subkey) => {
                      let thevalue: String = subkey.get_value(regvalue).unwrap_or_default();
                      let iniline: String = format!("{}\\{}={}\n", regpath, regvalue, thevalue);
                      let binaryiniline = iniline.as_bytes();
                      inifile.write_all(binaryiniline).expect("could not write line");
                      },
                  Err(_error) => {
                      let iniline: String = format!("{}\\{}={}\n", regpath, regvalue, "");
                      let binaryiniline = iniline.as_bytes();
                      inifile.write_all(binaryiniline).expect("could not write line");
                      },
                  };

Your thevalue is a "stringified" representation of the registry value, so numbers will be written in decimal. If you actually want to get at the type, use a "raw value" instead.

use winreg::enums::RegType::*;
            match subkey.get_raw_value(regvalue) {
                Ok(raw_value) => {
                    match raw_value.vtype {
                        REG_NONE => println!("None"),
                        REG_SZ => println!("null-teminated string"),
                        REG_EXPAND_SZ => println!("null-teminated string with variables"),
                        REG_BINARY => println!("blob"),
                        REG_DWORD => println!("64-bit number"),
                        REG_DWORD_BIG_ENDIAN => println!("64-bit number"),
                        REG_LINK => println!("null-terminated path"),
                        REG_MULTI_SZ => println!("null-terminated, null-separated, list of strings"),
                        REG_RESOURCE_LIST => println!("list of resources"),
                        REG_FULL_RESOURCE_DESCRIPTOR => println!("resource"),
                        REG_RESOURCE_REQUIREMENTS_LIST => println!("dependencies"),
                        REG_QWORD => println!("128-bit number"),
                    }
                }
                Err(_) => unimplemented!(),
            }

SmuSmu · January 9, 2020, 12:02pm

Yeah that helped a lot. Now it looks even more crappy but hey it works. Tanks

system · April 8, 2020, 12:02pm

This topic was automatically closed 90 days after the last reply. New replies are no longer allowed.