Please review async framed protocol API

Schard · October 11, 2024, 12:25pm

After some final rewriting, after receiving a lot of help, here's my latest take on an API to support the ASHv2 protocol

github.com

PaulmannLighting/ashv2/blob/1bfbcbaa89eea5cfed184ccb84415a0d443d7efb/src/ash_framed.rs

use crate::Request;
use std::io::ErrorKind;
use std::sync::mpsc::{sync_channel, Receiver, SyncSender};
use std::sync::{Arc, Mutex};
use std::task::{Poll, Waker};
use std::thread::spawn;
use tokio::io::{AsyncRead, AsyncWrite, ReadBuf};

/// A framed asynchronous `ASHv2` host.
#[derive(Debug)]
pub struct AshFramed<const BUF_SIZE: usize> {
    sender: SyncSender<Request>,
    state: Arc<Mutex<SharedState>>,
}

impl<const BUF_SIZE: usize> AshFramed<BUF_SIZE> {
    /// Create a new `AshFramed` instance.
    #[must_use]
    pub fn new(sender: SyncSender<Request>) -> Self {
        Self {

This file has been truncated. show original

Please, roast me

system · January 9, 2025, 12:25pm

This topic was automatically closed 90 days after the last reply. We invite you to open a new topic if you have further questions or comments.

Topic		Replies	Views
Finding the right API for embedded framed protocol help	5	68	January 9, 2025
Tokio-alpha Framed incompatibility with async std	3	796	December 8, 2019
Is there something similar to Framed Codecs for creating Stream adapters? help	10	688	September 11, 2022
Implementing a binary protocol using tokio help	6	1007	October 28, 2022
Async-std v0.99.11 released! announcements	1	990	January 27, 2020

Please review async framed protocol API

Related topics