Is my project ready to be used and released

code review
1

Diamond/ repl based sensitive information vault

Is it ready or is there things must be done before I release it ? And use it myself.

2

I highly suggest running

cargo clippy

and taking action on every warning emitted. You currently have 54 warnings. Some of them are extremely simple to fix, some require some thought.

5 Likes
3

Your application feels stringly typed. E.g. in diamond/src/main.rs at 9806580200e8e85ad766086c136cc7073d6f1039 · mohammed-dev23/diamond · GitHub you match the commands against magic strings. Consider introducing a command enum, which you can parse from a string and matching its variants instead. This would also allow you to

  1. Add associated data to the respective commands.
  2. Implement actions for the respective commands.

See e.g. rustymines/cli/src/action.rs at main · conqp/rustymines · GitHub and rustymines/engine/src/game/action.rs at main · conqp/rustymines · GitHub

3 Likes
4

let's ignore that TOTP is stored in plain text... why base64 everywhere? :sob:

5

I fixed that , now every thing has it's own key driven from the master key using hkdf

1 Like