How to make this thread safe?

kingwingfly · July 25, 2024, 1:21pm

I used to, :

kingwingfly/encrypt-config/blob/b8d4f1c322a2a294cbc62f8e45723ec2bf8cb72b/encrypt-config/src/config.rs#L24-L47


      
          impl Cache {
              fn get_or_default<T: Source + Any + Send + Sync>(&self) -> &CacheValue {
                  // SAFETY: The inner value is behind a RwLock.
                  let map = unsafe { &mut *self.inner.get() };
                  map.entry(TypeId::of::<T>()).or_insert(CacheValue {
                      inner: RwLock::new(Box::new(T::load_or_default())),
                  })
              }
          
              fn take_or_default<T: Source + Any + Send + Sync>(&self) -> T {
                  // SAFETY: UnsafeCell is used to allow interior mutability.
                  let map = unsafe { &mut *self.inner.get() };
          
                  match map.remove(&TypeId::of::<T>()) {
                      Some(value) => *value
                          .inner
                          .into_inner()
                          .expect("EncryptConfig: Rwlock is poisoned")
                          .downcast()
                          .unwrap(),

This file has been truncated. show original

But I just want to remove all the locks...

Topic		Replies	Views
Help understanding unsafe code with SyncUnsafeCell help	6	305	August 18, 2024
Atomic-synchronized UnsafeCell code review	6	982	June 4, 2022
Sanity and correctnes of my toy `OnceLock` implementation? code review	5	160	March 8, 2025
Alternative to Mutexs, When code is sound without them	4	795	February 20, 2023
Is this (toy) use of UnsafeCell sound? help	4	398	December 10, 2022

How to make this thread safe?

Related topics